[mlir][vector][NFC] Add deprecation notice to splat's .td #149532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-mlir-vector @llvm/pr-subscribers-mlir Author: James Newling (newling) ChangesPart of deprecation of vector.splat RFC: https://discourse.llvm.org/t/rfc-mlir-vector-deprecate-then-remove-vector-splat/87143/4 Full diff: https://github.com/llvm/llvm-project/pull/149532.diff 1 Files Affected:
diff --git a/mlir/include/mlir/Dialect/Vector/IR/VectorOps.td b/mlir/include/mlir/Dialect/Vector/IR/VectorOps.td
index cbe490f6e4dd1..d32347e1fee01 100644
--- a/mlir/include/mlir/Dialect/Vector/IR/VectorOps.td
+++ b/mlir/include/mlir/Dialect/Vector/IR/VectorOps.td
@@ -2919,6 +2919,8 @@ def Vector_SplatOp : Vector_Op<"splat", [
]> {
let summary = "vector splat or broadcast operation";
let description = [{
+ Note: This operation is deprecated. Please use vector.broadcast.
+
Broadcast the operand to all elements of the result vector. The type of the
operand must match the element type of the vector type.
@@ -2928,6 +2930,13 @@ def Vector_SplatOp : Vector_Op<"splat", [
%s = arith.constant 10.1 : f32
%t = vector.splat %s : vector<8x16xf32>
```
+
+ This operation is deprecated, the preferred representation of the above is:
+
+ ```mlir
+ %s = arith.constant 10.1 : f32
+ %t = vector.broadcast %s : f32 to vector<8x16xf32>
+ ```
}];
let arguments = (ins AnyType:$input);
|
kuhar
approved these changes
Jul 18, 2025
Member
kuhar
left a comment
kuhar
left a comment
There was a problem hiding this comment.
Maybe worth adding to https://mlir.llvm.org/deprecation/?
Contributor
Author
Seems like a good place for such announcements, thanks for pointing this out. |
dcaballe
approved these changes
Jul 18, 2025
mahesh-attarde
pushed a commit
to mahesh-attarde/llvm-project
that referenced
this pull request
Jul 28, 2025
Part of deprecation of vector.splat RFC: https://discourse.llvm.org/t/rfc-mlir-vector-deprecate-then-remove-vector-splat/87143/4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of deprecation of vector.splat
RFC: https://discourse.llvm.org/t/rfc-mlir-vector-deprecate-then-remove-vector-splat/87143/4
More complete deprecation: #147818